Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(dsl): Support 'matchPhrase' query #172

Merged
merged 9 commits into from
Apr 23, 2023
Merged

(dsl): Support 'matchPhrase' query #172

merged 9 commits into from
Apr 23, 2023

Conversation

drmarjanovic
Copy link
Member

@drmarjanovic drmarjanovic commented Apr 22, 2023 •
edited
Loading

Description:

Resolves matchPhraseQuery in #91

  • Provided matchPhrase query.
  • Provided boost options both for match and matchPhrase queries.
  • Addressed warning for the example app.
  • Improved documentation (provided .).
  • Changed the way of constructing fields in paramsToJson methods.
  • Adapted existing and provided new tests.
  • Provided structure for the website.

@drmarjanovic drmarjanovic marked this pull request as ready for review April 22, 2023 20:11
@mvelimir mvelimir self-requested a review April 22, 2023 21:02
@markaya markaya merged commit 93966cb into main Apr 23, 2023
@markaya markaya deleted the match-phrase-query branch April 23, 2023 10:46
arnoldlacko
arnoldlacko reviewed Apr 24, 2023
View reviewed changes
modules/library/src/it/scala/zio/elasticsearch/HttpExecutorSpec.scala
checkOnce(genDocumentId, genTestDocument, genDocumentId, genTestDocument) {
(firstDocumentId, firstDocument, secondDocumentId, secondDocument) =>
for {
_ <- Executor.execute(ElasticRequest.deleteByQuery(firstSearchIndex, matchAll))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to delete everything if we're recreating the index between each test?

arnoldlacko
arnoldlacko reviewed Apr 24, 2023
View reviewed changes
modules/example/src/main/scala/example/api/ErrorResponse.scala
import zio.Chunk
import zio.json.{DeriveJsonEncoder, JsonEncoder}

final case class ErrorResponse(errors: ErrorResponseData)
Copy link
Collaborator

@arnoldlacko arnoldlacko Apr 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this result in a structure like:

{
   errors: {
      body: [
         "This is an error"
      ]
   }
}

?
Can we simplify that and also avoid naming a class with Data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnoldlacko arnoldlacko arnoldlacko left review comments

@markaya markaya markaya approved these changes

@mvelimir mvelimir mvelimir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drmarjanovic @arnoldlacko @markaya @mvelimir